Schema changes for PaymentProcessor and PaymentProcessorType to suppo… #15733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt apiv4 entities
|
(Standard links)
|
seamuslee001
commented
Nov 5, 2019
| @@ -43,6 +43,7 @@ public function testCreate() { | |||
| 'name' => 'Test_Payment_Processor', | |||
| 'title' => 'Test Payment Processor', | |||
| 'billing_mode' => 1, | |||
| 'class_name' => 'Payment_Dummy', | |||
There was a problem hiding this comment.
note that becaue there is no default value for class_name yet i am setting it as default is the reason for the changes here
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rt apiv4 entities
Overview
This is just the schema changes split off from #15624 to assist in the implmentation of these entities in APIv4
Before
Schema not clear
After
Schema clearer
@eileenmcnaughton should i do an upgrade for this do you think?