composer.{json,lock} - Make the "tplaner/when" exception for old PHP reproducible #15732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reproducible Overview -------- The library `tplaner/when` has an inaccurate dependency on php71 and requires special work to deploy on php70. Before ------ The `composer.lock` file was manually edited to make it runnable on php70. However, if you `rm composer.lock && composer install`, then it fails. After ----- The `composer.json` and `composer.lock` are more repeatable. If you run `rm composer.lock && composer install`, then it works. Comments -------- This adds a fairly ugly section. However, the good news is that it should be more transparent - which should make it easier to understand/remove later. As a general rule, we don't want to have `civicrm-core.git` depend on packages/versions that aren't published. This is a somewhat unusual edge-case - this package/version is published via `packagist.org`. If you run without this on php71+, then you still get a valid/equivalent package. All that we've done is to enable running on `php70` (when `civicrm-core` is a root project).
|
(Standard links)
|
|
Yeh its not great workaround but if Jenkins is ok with it i am ok with it, it at least means the transition to the normal package then will be simpler and also it should also mean that people can run composer update easier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The library
tplaner/whenhas an inaccurate dependency onphp71and requires special work to deploy onphp70.Before
The
composer.lockfile was manually edited to make it runnable onphp70.However, if you
rm composer.lock && composer install, then it fails.After
The
composer.jsonandcomposer.lockare more repeatable. If you runrm composer.lock && composer install, then it works.Comments
This adds a fairly ugly section. However, the good news is that it should
be more transparent - which should make it easier to understand/remove
later.
As a general rule, we don't want to have
civicrm-core.gitdepend onpackages/versions that aren't published. This is a somewhat unusual
edge-case - this package/version is published via
packagist.org. If yourun without this on php71+, then you still get a valid/equivalent package.
All that we've done is to enable running on
php70(whencivicrm-coreisa root project).
To head off MC's, I based this on top of another #15730 which also touches
composer.lock.