Minor refactors to support converting custom fields to datepicker fields #15711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added in _high, _low as the new ones & also _from & _to as I'm having some transitional issues
It's not part of the select clause so having it in there is confusing & mislead. No functional change as it's the next thin to be called either way
|
(Standard links)
|
|
Looks fine to me and yes this is covered in unit tests so merge on pass |
|
@eileenmcnaughton if this misses the RC then that is probably ok, i'm thinking reports may also miss it even tho i got it pretty well packaged up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A couple of minor cleanups - one 'broadens' the code that determines what custom fields are in play on the first round rather than relying on them to be identified later. The other moves code that is not strictly 'select' code out of the select clause
Before
Code nasty
After
Still pretty nasty
Technical Details
@seamuslee001 I've been wrestling with the query on custom fields which is pretty nasty (boo) but tested (yay) and I think it might take a few refactors to get it there. I think it may miss the rc (boo) but it's hard going (also boo). This just fixes some inconsistencies that appear to be part of the pain (small yay) or the confusingness (small yay)
Comments