dev/core#561 Add in Upgrade routine to convert log_date smart group s… #15702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
…earches to their new names Fix log date function call in upgrade
…efault as that matches the current form code and extend unit test to cover senario where no radio button was filled in
seamuslee001
force-pushed
the
log_date_smart_group_upgrade
branch
from
6c67407 to
3a431ea
Compare
|
@seamuslee001 this is good to merge I think - you just need to merge mine first if it's OK - I think the UI issues related to mine are 'no worse than before' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…earches to their new names
Overview
This adds in an upgrade process for converting from the 1 log_date search field to the 2 new search fields of created_date and modified_date as per #15693
Before
1 Field in smart group searches
After
Correct Fields in smart group searches
ping @eileenmcnaughton