Add in method to allow extensions to opt out of using temporary table…

[seamuslee001]

… when building ACL Contact Cache

Overview

This adds in getter and setter functions and a static class variable to determine if temporary table should be used when building the ACL contact Cache

Before

Temporary Table always used

After

Temporary table used by default unless class variable set to not

Technical Details

in AUG we use the Multisite extension and one of the permissions it adds is "View all Contacts in domain" which is separate from View All Contacts so the core code when say loading an mailing will trigger a cache build. In one of our domains we have > 400K contacts that users with the permission View all contacts in domain for that domain can see which means we can easily run into Temporary Table is full errors. This was after we had increased the tmp_table_size and max_heap_table_size variables. So this gives us a way of using either the multisite extension or some other extension telling it to not use a temporary table to build the ACL Contact Cache for these users

ping @eileenmcnaughton @mattwire @monishdeb

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 OK - but the fact you need this points to the source of your performance issues..... so you are still getting a performance improvement with the fixed-up-locks only?

[seamuslee001]

@eileenmcnaughton yes we are however its now run into this other problem which isn't a performance issue more blocker on people doing work, we are planning to put this in very early next week

[eileenmcnaughton]

OK - I think this had better be in the same release as adding temp tables as possible