Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in upgrade step for upgrading Event date and Relationship Active Date smart groups #15677

Merged

Conversation

seamuslee001
Copy link
Contributor

Overview

This handles the upgrade process for smart groups following the jcalendar to datepicker conversion in #15661

Before

Smart Groups not converted

After

Smart Groups converted

Technical Details

Unlike many other forms you can create smart groups in find participant search which stores it in format of => rather than in [, , ] format

Comments

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Oct 31, 2019

(Standard links)

@civibot civibot bot added the master label Oct 31, 2019
@seamuslee001 seamuslee001 force-pushed the event_smart_group_upgrade branch from 3a6c602 to 0cdb874 Compare October 31, 2019 21:12
@eileenmcnaughton
Copy link
Contributor

Thanks for getting your head around that @seamuslee001 - the tests look good & we had existing test cover on the other patterns so if you can sell jenkins on it I'm good with i

Include relation_active_period_date field for upgrade
@seamuslee001 seamuslee001 changed the title Add in upgrade step for upgrading Event date smart groups Add in upgrade step for upgrading Event date and Relationship Active Date smart groups Oct 31, 2019
@seamuslee001 seamuslee001 force-pushed the event_smart_group_upgrade branch from 6917b8d to c143680 Compare October 31, 2019 22:54
@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton i have included the relationship active date upgrade in this now and confirmed locally that it works

@seamuslee001 seamuslee001 merged commit 8ccf5aa into civicrm:master Nov 1, 2019
@seamuslee001 seamuslee001 deleted the event_smart_group_upgrade branch November 1, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants