Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Remove unreachable lines #15672

Merged
merged 1 commit into from
Oct 31, 2019
Merged

[NFC] Remove unreachable lines #15672

merged 1 commit into from
Oct 31, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 31, 2019 •
edited
Loading

Overview

Removes a few lines of code that are logically unreachable

Before

Lines exist

After

Poof

Technical Details

Right before them an exception is thrown meaning they will never be hit

Comments

@civibot
Copy link

civibot bot commented Oct 31, 2019

(Standard links)

@civibot civibot bot added the master label Oct 31, 2019
@eileenmcnaughton eileenmcnaughton changed the title Remove unreachable lines [NFC] Remove unreachable lines Oct 31, 2019
@colemanw
Copy link
Member

Poof! 💥

@colemanw colemanw merged commit 69f7f66 into civicrm:master Oct 31, 2019
@colemanw colemanw deleted the unreachable branch October 31, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw