dev/core#1348 - backport of PR 15654

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/issues/1348
A change in the base class form value handling in 5.19 makes the activity search form not work anymore. It just always returns all results.

Before

Any activity search always returns all results.

After

Form field values get picked up.

Technical Details

CRM_Core_Form_Search::setFormValues() was changed to call $this->getFormValues(), but activity search already has such a function that just returns null. It doesn't seem to be used though, and removing it seems to work and looking at the related 5.18.4 code it's mostly the same.

Comments

Backport of #15654

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

I tested this and confirmed that it causes the form to work correctly in 5.19 and this is consistent with what we have done on the case form. Merge on Pass

[seamuslee001]

Test fail unrelated merging