dev/core#1347 - Fix php warning in advanced search when opening some accordions #15650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -302,7 +302,8 @@ public static function getModeValue($mode = CRM_Contact_BAO_Query::MODE_CONTACTS | |||
| } | |||
|
|
|||
| self::setModeValues(); | |||
| if (!array_key_exists($mode, self::$_modeValues)) { | |||
There was a problem hiding this comment.
or we could cast to an array
if (!array_key_exists($mode, (array) self::$_modeValues)) {
There was a problem hiding this comment.
Would that help because the warning is the first param, because of the array_search above $mode sometimes ends up being FALSE.
|
@demeritcowboy is this a 5.19 regression? or is master the right choice? |
|
I saw it in 5.14 too. And it doesn't affect search results. |
|
cool - good to go then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/issues/1347
When opening some accordions on advanced search, the accordion might not have a mapping for $mode, so $mode ends up being false, which gives a warning when used in array_key_exists. The warning doesn't show on screen for some reason, even if you have messages to the screen enabled, but does show up in drupal watchdog.
Before
Warning: array_key_exists(): The first argument should be either a string or an integer in CRM_Contact_Form_Search::getModeValue() (line 305 of .../CRM/Contact/Form/Search.php)After
""
Technical Details
I wasn't sure if the right fix is to add a mapping, but I'm not sure even what effect the code has anyway because even when there is a mapping e.g. for the activities section, at the point the warning is appearing it still doesn't actually change the mode, which is controlled by the mode field at the top of the form.
Comments