Cleanup following smart group conversions and fix the old name of the… #15648
Conversation
|
(Standard links)
|
| @@ -540,9 +540,6 @@ public static function relationship(&$form) { | |||
| } | |||
| CRM_Core_Form_Date::buildDateRange($form, 'relation_active_period_date', 1, '_low', '_high', ts('From:'), FALSE, FALSE); | |||
|
|
|||
| // Add reltionship dates | |||
There was a problem hiding this comment.
I couldn't see this field exposed at all on the form so lets bin it
There was a problem hiding this comment.
@eileenmcnaughton looks like this is when the relation_date field was stripped off the form ad68213#diff-0ac8fd8c66c6d1e69b6dafa540ecddbf
|
OK- I feel like we reached agreement that relation_date didn't do much - so this looks good to me |
|
@seamuslee001 fail relates |
… relationship date relative fields for conversion and add a unit test
seamuslee001
force-pushed
the
relationship_date_cleanup_fixes
branch
from
434e025 to
0d679de
Compare
|
@eileenmcnaughton i have fixed the test but can you check your ok with the test fix? |
|
So why did the participant field need to come out? |
|
@eileenmcnaughton AFAIK it has already been converted to datepicker so why should we keep it in? |
|
Ok per discussion on chat this seems fine - we are removing the ability to do weird saving except for our 3 remaining fields |
| */ | ||
| public static function saveRelativeDates(&$queryParams, $formValues) { | ||
| // This is required only until all fields are converted to datepicker fields as the new format is truer to the | ||
| // form format and simply saves (e.g) custom_3_relative => "this.year" | ||
| $relativeDates = ['relative_dates' => []]; | ||
| $specialDateFields = [ | ||
| 'event_relative', | ||
| 'participant_relative', |
There was a problem hiding this comment.
this list (now of only 3 fields) is the list of legacy fields
… relationship date relative fields for conversion and add a unit test
Before
No unit test on the relationship conversion
After
Unit test
Technical Details
The unit test was mostly built off the smart group values found here #15637 (comment) with the field names already re-worked