[REF] Further deconstruction of updateFinancialAccounts #15631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updateFinancialAccounts is only called from one place with the context of 'changedStatus'. When called this way the function updateFinancialAccountsOnContributionStatusChange is called & that 'tells' the calling function whether to call the rest of this function. Since this handling is specific to one place from which the function is called we can move that logic back to the place that calls it & further simplify the updateFinancialAccounts function which has been a bit of a haven of chaos
|
(Standard links)
|
| @@ -3691,7 +3691,10 @@ public static function recordFinancialAccounts(&$params, $financialTrxnValues = | |||
| $params['prevContribution']->contribution_status_id != $params['contribution']->contribution_status_id | |||
| ) { | |||
| //Update Financial Records | |||
| self::updateFinancialAccounts($params, 'changedStatus'); | |||
| $callUpdateFinancialAccounts = self::updateFinancialAccountsOnContributionStatusChange($params); | |||
There was a problem hiding this comment.
this var isn't strictly needed but I used it because the function being called does not do a good job of implying the meaning of it's return value
|
@seamuslee001 are you ok to merge this- the code has a LOT of unit tests covering it |
|
Took me a while to try and get my heads around this but it looks fine to me merging |
|
@seamuslee001 took me a while to simplify the code enough for that change to be do-able :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Further incremental code cleanup step in updateFinancialAccounts
Before
non-generic code in generic function
After
non generic code in the bit of function it relates to
Technical Details
updateFinancialAccounts is only called from one place with the context of 'changedStatus'. When called this
way the function updateFinancialAccountsOnContributionStatusChange is called & that 'tells'
the calling function whether to call the rest of this function.
Since this handling is specific to one place from which the function is called we can move that logic
back to the place that calls it & further simplify the updateFinancialAccounts function
which has been a bit of a haven of chaos
Comments