Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete supportStorageOfAccents() method. #15589

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

mfb
Copy link
Contributor

@mfb mfb commented Oct 23, 2019

Overview

I found that CRM_Utils_SQL::supportStorageOfAccents() is unused. The documentation states "This function should not be used as the basis of further work as the reasoning is not perfact and is giving false failures" so my thinking was that the public method could be removed without first being deprecated. The one usage was removed a year ago in commit 2fc6408.

Before

CRM_Utils_SQL::supportStorageOfAccents() is a thing.

After

CRM_Utils_SQL::supportStorageOfAccents() is not a thing.

@civibot
Copy link

civibot bot commented Oct 23, 2019

(Standard links)

@civibot civibot bot added the master label Oct 23, 2019
@colemanw
Copy link
Member

I checked and the function is indeed unused.

@colemanw colemanw merged commit f51963f into civicrm:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants