Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] minor extraction in dedupe code #15587

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 23, 2019

Overview

Extract part of the function to build the location blocks

Who hates the variable 'moniker'?

Before

Less readable. Moniker's name taken in vain

After

More readable. Little bit of Moniker not by my side

Technical Details

Pretty straight forward code cleanup - well tested

Comments

@civibot
Copy link

civibot bot commented Oct 23, 2019

(Standard links)

@civibot civibot bot added the master label Oct 23, 2019
@eileenmcnaughton
Copy link
Contributor Author

And that was the proof of the good test cover :-)

@mattwire
Copy link
Contributor

Much cleaner

@mattwire mattwire merged commit 6e2ae18 into civicrm:master Oct 23, 2019
@eileenmcnaughton eileenmcnaughton deleted the dedupe branch October 23, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants