Issue 1205: allow custom fields of type file for entities

[jaapjansma]

Overview

The attachment API gives a permission denied on custom file fields on events (and other entities).
This PR removes the white list and removing the white list will check the Attachment API against core entities (even custom ones defined in extensions).

See: https://lab.civicrm.org/dev/core/issues/1205

Before

Attachment API on a file uploaded to a custom file field to an event would fail with permission denied.

After

Attachment API on a file uploaded to a custom file field to an event would succeed when the user also has access to the connected entity (in this case the event).

Technical Details

I have chosen to remove only the definition of the white list. I could have removed the white list but that got me into a corner where I had to redo the DynamicFKAuthorizationTest.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@totten this whitelist has been problematic for a while...

[jaapjansma]

Same PR here: #15575

[seamuslee001]

Test failure is related here

[jaapjansma]

The test was failing because it succeeded at creating an attachment to the CRM_Core_DAO_Domain entity.
Previously only whitelisted entities where allowed and should succeed. As we have disabled the whitelist it is now possible to attach file to the CRM_Core_Domain entity (does not make sense from use perspective).

So I have updated the test to check whether attaching a file to CRM_Core_DAO_Domain succeeds.

[eileenmcnaughton]

This has had pretty good analysis on gitlab. I've marked this merge-ready to give @totten one last chance to raise a red flag but if no comments in the next couple of days let's merge

[eileenmcnaughton]

OK - no response - merging