Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Settings Pages: Make getSettingPageFilter() public so we can use it in hooks #15576

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Generic Settings Pages: Make getSettingPageFilter() public so we can use it in hooks #15576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CRM/Admin/Form/SettingTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,11 @@ protected function getSettingMetadataItem($setting, $item) {
}

/**
* This is public so we can retrieve the filter name via hooks etc. and apply conditional logic (eg. loading javascript conditionals).
*
* @return string
*/
protected function getSettingPageFilter() {
public function getSettingPageFilter() {
if (!isset($this->_filter)) {
// Get the last URL component without modifying the urlPath property.
$urlPath = array_values($this->urlPath);
Expand Down