Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

civicrm_webtest.install - Backdrop support for adding roles and perms #15571

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Conversation

herbdool
Copy link
Contributor

Overview

This addresses https://lab.civicrm.org/infra/ops/issues/906#note_21974 so that the webtest install supports Backdrop.

Before

Can't build a Backdrop/CiviCRM site with demo user that has the right permissions.

After

Can.

@civibot
Copy link

civibot bot commented Oct 21, 2019

(Standard links)

@civibot civibot bot added the master label Oct 21, 2019
@eileenmcnaughton
Copy link
Contributor

This doesn't touch any 'live' code so I'm going to defer to @herbdool as the backdrop expert

@eileenmcnaughton eileenmcnaughton merged commit 00ed72c into civicrm:master Nov 3, 2019
@totten totten changed the title Backdrop support for adding roles and perms civicrm_webtest.install - Backdrop support for adding roles and perms Nov 3, 2019
@totten
Copy link
Member

totten commented Nov 3, 2019

Oh, nice - that does look simpler than extracting the permission list. :)

I triggered a new build (1984) of the dmaster and bmaster demo sites so that we can double-check that the demo user gets suitable perms on both builds. dmaster still works. 👍 For bmaster, I manually activated civicrm_webtest.module:

Screen Shot 2019-11-03 at 3 06 03 PM

This does seem to have created the role with permissions:

Screen Shot 2019-11-03 at 3 10 34 PM

Adding the demo user to that role works as expected - they get access to "CiviCRM" in the menu. 👍

One small oddity - I'm not sure i f it's related to this module/patch, the warnings above, or something else - but there's an unnamed role on the demo site:

Screen Shot 2019-11-03 at 3 13 59 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants