Fix bug whereby cidZero does not prepopulate billing details for selected contact for pay later.

[eileenmcnaughton]

Overview

Fixes a pretty obscure bug when selecting a different contact to fill in the form for

To replicate

1. create a contribution page & select pay later (and no other processor) with 'billing address required'
2. access the contribution page with cid=0 in the url
3. select a contact - witness the contacts detaisl have NOT loaded into the billing block
4. follow the same steps on event

Before

Prefill after selecting contact:

After

Prefill after selecting contact:

Technical Details

I was trying to reduce complexity on this form for another change (exposing payment processor title if available) when I realised that the variable
to determine whether to show the block was wrong in the scenario when billing details were required for
pay later .On testing there seemed now downside (other than a very minor performance
hit in obscure circumstances) in just always loading the billing profile details.

I saw no js error when the billing block was NOT present and we are already checking
the person has access to see the contact so that is not an issue here (Profile.get
does a permission check

Comments

@kcristiano are you able to test & see if you agree with this?

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[kcristiano]

@eileenmcnaughton I was able to test. I can re-create the same lack of billing info following the steps to reproduce.

Applying the patch fixes the issue.

[eileenmcnaughton]

Thanks @kcristiano