dev/core#1335 - Prevent php warning when saving case type

[demeritcowboy]

Overview

htmlspecialchars is being passed an array sometimes. It also prevents unit tests from running if they do something like retrieve a case type via api and then try to save it again even without changing anything.
https://lab.civicrm.org/dev/core/issues/1335

Before

As described in the lab ticket there's warnings in drupal watchdog. Also the attached added test gives 3 fails:

CRM_Case_BAO_CaseTypeTest::testConvertDefinitionToXml
CRM_Case_BAO_CaseTypeTest::testRoundtrip_XmlToJsonToXml
CRM_Case_BAO_CaseTypeTest::testRoundtrip_JsonToXmlToJson

htmlspecialchars() expects parameter 1 to be string, array given
.../CRM/Case/BAO/CaseType.php:222
.../CRM/Case/BAO/CaseType.php:154

After

Better

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@demeritcowboy Thanks, technically this introduces a small changes as we insert NULL into the string instead of ''. But in practise I don't think that makes any difference!

[demeritcowboy]

Thanks. Actually @mattwire I realized after first trying '' that htmlspecialchars returns null when passed an array, so this is as close to NFC as I could get. And it does seem to make a difference when using ''.