Support chaining Payment.create from Order api #15548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
order
branch
from
70ac08e to
992ef01
Compare
aydun
reviewed
Oct 19, 2019
api/v3/Order.php
Outdated
| @@ -92,8 +92,9 @@ function civicrm_api3_order_create($params) { | |||
| $entityIds = []; | |||
| $contributionStatus = CRM_Utils_Array::value('contribution_status_id', $params); | |||
| if ($contributionStatus !== 'Pending' && 'Pending' !== CRM_Core_PseudoConstant::getName('CRM_Contribute_BAO_Contribution', 'contribution_status_id', $contributionStatus)) { | |||
| CRM_Core_Error::deprecatedFunctionWarning('Creating a Order with a status other than pending is deprecated. Currently empty defaults to "Completed" so as a transition not passing in "Pending" is deprecated'); | |||
| CRM_Core_Error::deprecatedFunctionWarning("Creating a Order with a status other than pending is deprecated. Currently empty defaults to 'Completed' so as a transition not passing in 'Pending' is deprecated. You can chained payment creation like - civicrm_api3('Order', 'create', ['blah' => 'blah', 'contribution_status_id' => 'Pending', 'api.Payment.create => ['total_amount' => 5]]"); | |||
There was a problem hiding this comment.
Grammar: "You can chained payment creation like -" Maybe "You can chain payment creation - for example:"
There was a problem hiding this comment.
thanks - fixed
eileenmcnaughton
force-pushed
the
order
branch
from
992ef01 to
b6ffb8f
Compare
|
test this please |
eileenmcnaughton
force-pushed
the
order
branch
from
b6ffb8f to
e2887a3
Compare
|
test this please |
1 similar comment
|
test this please |
|
@seamuslee001 @monishdeb @mattwire is one of you good to merge this - I can fix the Extended Reports tests once merged |
|
This looks fine to me, backed up by a unit test and makes sense |
|
Thanks @seamuslee001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Now that we have deprecated creating an order without passing the status of 'Pending' I'm having to switch over some tested code. I quickly realised that supporting chaining would be really helpful here.
This PR creates the tests and code to make this work
Before
Above call fails
After
Above call passes & is tested
Technical Details
@JoeMurray @mattwire @artfulrobot @aydun
Comments
Note the impact of the deprecation is to show notices - this causes tested code to start failing if it hits the deprecation - this is a good thing.
@seamuslee001 I'll fix the extended reports tests once this is merged