dev/core#1324 Adds missing join on the customtable of address customfields while exposed as profile

[VangelisP]

Overview

This PR is adding a LEFT JOIN to the missing address customfields so that the query can function properly.
This is related to issue : https://lab.civicrm.org/dev/core/issues/1324

Before

A LEFT JOIN was missing from the table, resulting in a DB Error: no such field (field was included in the query but had no source to connect to)

After

Query executes properly

Technical Details

As this PR affects the CRM/Contact/BAO/Query.php , it's very important to be reviewed properly.

Comments

Please review it thoroughly.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[VangelisP]

@eileenmcnaughton I don't understand why this error E2E\Core\PrevNextTest::testDeleteByCacheKey kicks in and fails the check. Any clues?

[eileenmcnaughton]

@VangelisP it's a known intermittant error - we haven't gotten to the bottom of. If it's the only one you can ignore - although I might trigger them again so hopefully there will be a green tick when we come to review

[eileenmcnaughton]

test this please

[eileenmcnaughton]

I was able to replicate this fatal error in the UI & in a unit test (which I will submit). This is being added in a safe place & looks correct to me - with the test it will be locked in