dev/core#1317 - Fix total_amount on repeattransaction when tax amount is involved.

[jitendrapurohit]

Overview

Fix total amount on repeattransaction when done for FT having tax.

Before

To replicate -

• Create an FT that includes a 10% GST on the main amount.
• Sign up an auto-renew Membership using this FT. So if membership amount is $10, the total amount paid by the user is $11.
• Now, when the next recur needs to be processed, if repeattransaction is called on this recur contribution, it recalculates the tax on the already taxed amount. So the second payment will be recorded with total amount = $12.1.
• Every repeattransaction api on this recur contribution will calculate incorrect total amount for the new payment. So, the next payment will have 12.1 + 10% followed by 12.1 + 10% + 10%.

After

Fixed. Each repeattransaction will have the same amount as the original contribution.

Comments

Gitlab - https://lab.civicrm.org/dev/core/issues/1317

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This seems to make sense to me @mattwire @eileenmcnaughton

[eileenmcnaughton]

Yes this makes sense & test is good - thanks @jitendrapurohit - merging