WIP Contribution.transact API alternative transitional version

[mattwire]

Overview

Let's see if unit test pass

Before

The current status. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.

After

What has been changed. Please provide screenshots or gifs (LICEcap, SilentCast) where appropriate.

Technical Details

If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary

Comments

Anything else you would like the reviewer to note

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@mattwire if this is for webform why doesn't it just implement it's own api rather than try to change a core api that does very little badly?

[mattwire]

@eileenmcnaughton This is really just to see if we actually have anything that can replace Contribution.transact without lot's of extra code. And Order.create + Paymentprocessor.pay are still not quite "mature" as we've found from the sprint so potentially wrapping them both here gives us more flexibility to tweak them before we force people to stop using transact. Alternatively this PR might just get used to generate docs on how to interact with Order/Pay.

[eileenmcnaughton]

@mattwire forcing them to stop using this api would mean removing it - I think we should deprecate as is but I don't think we should remove it

[mattwire]

See also #15340

[mattwire]

@mattwire forcing them to stop using this api would mean removing it - I think we should deprecate as is but I don't think we should remove it

This just continues the pain for payment processor authors as the site users just expect them to work! See #15504 for a compromise which I'm hoping is acceptable to everyone at this stage?

[eileenmcnaughton]

I've been obviously snowed since the sprint & am not following this ( or several other) issues but rather trying to get on top of the various discussions we had at the sprint about the order api & getting stuff onto it

I just added this about how migrating off transact api should look civicrm/civicrm-dev-docs#705 -I think that documentation step is important because I can then point to it when I put up the PR we agreed was needed to deprecate the Contribute.transact api

I'm also working on a metaissue to track the various things - but it only just started at the moment

[mattwire]

Closing in favour of #15504 which I think satisfies all requirements as it makes no actual "changes" in core.