The loop doth process too much, methinks

[demeritcowboy]

Overview

The loop is too loopy. It doesn't need to be so loopy. See also the recent commit which is the same loop in a different spot but correctly doesn't loop too much.

Before

Maximum loopiness, all day and all night.

After

The exact right amount of loopy.

Technical Details

Before commit 8913e91 it was hardcoded to 5 in this spot, so it was often too loopy but not too much. After that commit with the default new max setting it would loop 100 times every time.

Comments

Related to change made for https://lab.civicrm.org/dev/core/issues/1270

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Makes sense merging