dev/financial#72 Filter contribution status lists for batch creation and update #15472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing pseudoConstant calls with BAO buildOptions in 'search' context. This commit is only intended to touch places where we are building a list of options to offer to the user, not places where we are displaying results. In practice this doesn't remove any currently available statuses, but now we can filter our the proposed 'Template' status.
Replacing pseudoconstant calls in batch creation/update using CRM_Contribute_BAO_Contribution_Utils::getContributionStatuses(). This actually changes the list of options offered, but all the ones it removes should probably already have been gone.
|
(Standard links)
|
|
Thanks @ejegg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use a standard function to create contribution status dropdowns for batch contribution entry and batch pending contribution status update task.
Before
Irrelevant statuses are offered when users are trying to update or enter a batch of contributions. When a developer adds a new status, they have to update filters in many places in code.
After
Batch entry and update status dropdowns are filtered through a common function which takes context into account.
Technical Details
Clarifies bulk update dropdown filtering (which should move) to unset by name instead of int.
Comments
Anything else you would like the reviewer to note