Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#1285) Support for importing "campaign_id" (& other fields where it could be an ID, name or label) #15453

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fixes a change / regression where the id stopped working as a valid option when importing campaigns for contributions

Before

Only name or label work

After

id, name & label work (in that order)

Technical Details

After digging into https://lab.civicrm.org/dev/core/issues/1285 it feels a little arguable what we should support but issues in
gitlab indicate there is at least some demand for id & label so it now will

  • accept id if input matches an id
  • accept name if input matches a name
  • accept label if input matches a label.

This means for payment instrument it would accept '1', 'Check' or 'Cheque' (in that order if name were renamed).

This should apply to a few fields - payment instrument, constribution status & per the issue campaign
(on contribution). There are 'some' on membership too I think

Comments

@civibot
Copy link

civibot bot commented Oct 8, 2019

(Standard links)

@civibot civibot bot added the 5.19 label Oct 8, 2019
… could be an id, a name or a label.

After digging into https://lab.civicrm.org/dev/core/issues/1285 it feels a little arguable what we should support but issues in
gitlab indicate there is at least some demand for id & label so it now will
- accept id if input matches an id
- accept name if input matches a name
- accept label if input matches a label.

This means for payment instrument it would accept '1', 'Check' or 'Cheque' (in that order if name were renamed).

This should apply to a few fields - payment instrument, constribution status & per the issue campaign
(on contribution). There are 'some' on membership too I think
@seamuslee001 seamuslee001 merged commit cce82f6 into civicrm:5.19 Oct 9, 2019
@eileenmcnaughton eileenmcnaughton deleted the import_campaign branch October 9, 2019 09:06
@totten totten changed the title dev/core#1285 import support for campaign_id (& other fields where it could be an id, a name or a label. (dev/core#1285) Support for importing "campaign_id" (& other fields where it could be an ID, name or label) Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants