Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status check not rendering before 5.19 migrations #15428

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

pfigel
Copy link
Contributor

@pfigel pfigel commented Oct 7, 2019

Overview

Fix an issue where the status check page does not render when migrations to 5.19 are pending.

Before

Status check page does not render on sites that haven't run the 5.19 migration because the is_active column doesn't exist yet.

After

Status check page renders.

Comments

The rationale for this change is to avoid scenarios where users forget to run upgrades because there's no status check warning. The try/catch can be removed at some point after 5.19 is released (will file a ticket after this is merged).

This fixes an issue where the status check page does not render when
migrations to 5.19 are pending because the is_active column hasn't been
added yet.

The rationale for this change is to avoid scenarios where users forget
to run upgrades because there's no status check warning.
@civibot
Copy link

civibot bot commented Oct 7, 2019

(Standard links)

@civibot civibot bot added the 5.19 label Oct 7, 2019
Copy link
Contributor

@seamuslee001 seamuslee001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urg but ok makes sense I guess

@demeritcowboy
Copy link
Contributor

Just adding that it's not just that the status page doesn't render, you get a fatal db error if an admin hasn't logged in for longer than the status check interval, because it then tries to run the check as soon as they hit any civi page.

@eileenmcnaughton eileenmcnaughton merged commit 41c0e58 into civicrm:5.19 Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants