Remove legacy Yahoo references from the Mapping/Geocoding settings/code. #15405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove references to Yahoo Geocoder which is no longer included core.
The Yahoo mapping provider is no longer in core and therefore this conditional logic is no longer necessary.
|
(Standard links)
|
|
Looks pretty sensible. Related background: https://issues.civicrm.org/jira/browse/CRM-19784 |
|
Added merge on pass based on @totten 's comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes the references to the Yahoo mapping provider and geocoder from settings help test, from conditional logic and finally adds OSM to the Task Checklist to finalise the removal of the Yahoo remnants.
Before
References remain to the removed Yahoo mapping and Geocoding services in the Civi interface.
After
The references are removed.
Technical Details
None
Comments
None