Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#861 Ensure that when processing mailings that no emails are … #15404

Merged
merged 1 commit into from
Oct 6, 2019

Conversation

seamuslee001
Copy link
Contributor

…sent to deceased contacts or those with emails now on hold

Overview

This resurects #14020 from Yash by adding a test and also expanding the checks so that for SMSes we also exclude deceased contacts

Before

Newly deceased contacts may get mailed if mailing scheudled before contact is marked as deceased

After

No deceased contacts emailed or smsed

ping @eileenmcnaughton

…sent to deceased contacts or those with emails now on hold
@civibot civibot bot added the master label Oct 6, 2019
@civibot
Copy link

civibot bot commented Oct 6, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Merge on pass as this is a reviewer's cut

@eileenmcnaughton
Copy link
Contributor

@yashodha I've given this MOP as a reviewer's cut - perhaps you could double check it though.

@seamuslee001 seamuslee001 merged commit 5c4d78d into civicrm:master Oct 6, 2019
@seamuslee001 seamuslee001 deleted the dev_core_861 branch October 6, 2019 18:59
@yashodha
Copy link
Contributor

@seamuslee001 thanks!

@MegaphoneJon
Copy link
Contributor

@yashodha @seamuslee001 This PR seems to have caused a regression where "Enable multiple bulk email" setting is no longer respected: https://lab.civicrm.org/dev/mail/issues/60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants