Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core/1266 widget header tab next state to pcp tab #15323

Merged
merged 1 commit into from
Oct 13, 2019

Conversation

elisseck
Copy link
Contributor

Overview

When configuring a contribution page through the GUI, clicking save and next typically moves a user to the next tab header. Only on the last tab the user will get a "Save & Done" button that brings them back to the "Manage Contribution Pages" screen.

Currently the "Save & Next" button on the second-to-last tab (Widgets) boots the user back to "Manage Contribution Pages" instead of moving them to the "Personal Campaigns" tab as expected.

Issue: https://lab.civicrm.org/dev/core/issues/1266

Before

Clicking "Save and Next" on the Widgets tab when configuring a contribution page brings user back to the "Manage Contribution Pages" screen instead of to the "Personal Campaigns" tab for that contribution page config.

After

Clicking "Save and Next" on the Widgets tab when configuring a contribution page brings user to the "Personal Campaigns" tab for that contribution page config.

Technical Details

This is a workaround with a precedent (I have added a case to a state override switch already in place). It would probably be better if the state machine brought back useful class names for the widget, pcp, etc pages even though the class structure is different than the other tabs, but that would involve much bigger changes like moving classes around than this issue warrants.

@civibot
Copy link

civibot bot commented Sep 18, 2019

(Standard links)

@civibot civibot bot added the master label Sep 18, 2019
@elisseck
Copy link
Contributor Author

jenkins test this please

@mattwire mattwire merged commit 95df191 into civicrm:master Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants