dev/core#1262 - Fix case status order in case type settings page

[vinuvarshith]

Overview

In the case type settings/config page, where we have a tab for 'Case status' that lists all case statuses from which we can select the ones we want for that case type.
This list of case statuses are not ordered by their weight which would the correct way to list these.

Before

I have added a screenshot of the page when adding a new case type. In this the case status 'first' has the lowest weight and so I expect to see it on the top of the list.

After

Now the case statuses are sorted by their weight.

Technical Details

In crmCaseType.js, where case statues are obtained (reqs.caseStatuses), I have added 'sort: 'weight'' to the options array.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

• General standards
  • [r-explain] PASS
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] PASS Looks good to me. Basic tasks like creating/editing case types and creating/editing cases still works. It also still sorts properly on the case type edit screen if you uncheck one of the statuses.
• Developer standards
  • [r-tech] PASS
  • [r-code] PASS
  • [r-maint] N/A
  • [r-test] PASS