REF Move ipAddress and CC expiry date to prepareParamsForPaymentProcessor #15291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
changed the title
mattwire
changed the title
mattwire
changed the title
artfulrobot
reviewed
Oct 8, 2019
artfulrobot
reviewed
Oct 8, 2019
artfulrobot
reviewed
Oct 8, 2019
mattwire
force-pushed
the
formatpaymentparams_addccip
branch
from
df07a27 to
b0efa39
Compare
|
@artfulrobot Thanks for your review and comments. I've addressed them |
|
Merging based on @artfulrobot 's review and the fact Matt has responded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Following on from #15281 this moves two more common parameters into the shared function.
Before
$params['ip_address'] set separately in multiple places.
$params['year'/'month'] set separately in multiple places.
After
Parameters moved to shared function.
Technical Details
Comments
@mlutfy This includes adding this function to the event cart which should help improve support for payment processors there. Could you give it a quick test?