Ensure Dashboard domain ID is set even when passed as a param #15282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follows on from #15099 by fixing the identification of a Dashlet to update when
domain_id
is specified as a param when creating a Dashlet.Before
When a Dashlet with
name = 'blah'
already exists, then attempting to create a new one with a differentdomain_id
updates the existing one rather than creating a new Dashlet. This only occurs whendomain_id
is passed as a param.After
The code above correctly creates a Dashlet with the
domain_id
specified in the params.