Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/joomla#24) Stop CiviCRM's joomla.css from modifying Joomla 4 header background colour #15137

Merged

Conversation

andrewpthompson
Copy link
Contributor

Overview

See https://lab.civicrm.org/dev/joomla/issues/24.
This PR stops the Joomla 4 header from having its background colour modified to blue by CiviCRM's joomla.css

Before

When on a CiviCRM backend page the Joomla 4 header will change from white to blue background.
image

After

Joomla's header will have a white background as it does on non-CiviCRM pages.
image

Technical Details

Removed #header { background-color: #69c; } which seemed to have no purpose on earlier Joomla versions.

Comments

@civibot
Copy link

civibot bot commented Aug 26, 2019

(Standard links)

@civibot civibot bot added the master label Aug 26, 2019
@colemanw
Copy link
Member

@lcdservices can you confirm this fix?

@eileenmcnaughton
Copy link
Contributor

or @vingle

@eileenmcnaughton
Copy link
Contributor

@vingle @lcdservices the question is 'does this do any harm on the existing Joomla! version' - happy to accept @andrewpthompson's word on Joomla! 4 impact as that is WIP at this stage & will be maturing for a while

@vingle
Copy link
Contributor

vingle commented Sep 5, 2019

No harm to J 3.9.11 for me.

@eileenmcnaughton
Copy link
Contributor

Thanks

@eileenmcnaughton eileenmcnaughton merged commit a4e0e9e into civicrm:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants