Deprecate CRM_Core_Config::defaultContactCountry and defaultContactCountryName #15127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Ok I took a look & it seems OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Stop using deprecated CRM_Core_Config::defaultContactCountry() and defaultContactCountryName() in core and emit warnings if they are used.
Partial from #14576
Before
Deprecated functions used by core.
After
Deprecated functions not used by core.
Technical Details
Comments
@eileenmcnaughton In #14576 you said that you didn't think these functions were doing the same thing - but I can't see how that could be as one just calls the other?