Remove unused method CRM_Contact_BAO_Contact_Utils::maxLocations

[JKingsnorth]

Overview

The \CRM_Contact_BAO_Contact_Utils::maxLocations method has no usages. I checked this using IDE tools and then by grepping the codebase for the 'maxLocations' string. I also tried grepping the commit log and didn't see any other references to it other than the declaration.

So let's remove it?

(The other option would be to deprecate it and remove it later...)

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I agree

[mattwire]

@agh1 @eileenmcnaughton It would be really helpful to capture interface changes/removals like this as a separate section on the release notes - so that an extension developer checking compatibility with versions for example can see at a glance that the function is no longer available for this version, same with deprecated functions we're removing and signature changes. I'm proposing a new tag that you could scrape along with the PRs?

[JKingsnorth]

@mattwire Makes sense to me.

[agh1]

@mattwire at the moment no tags are scraped, but it does seem reasonable if the tagging is consistent and can align well with a section of the release notes.

The bigger question is about the signal, noise, and effort involved in highlighting every change to a BAO method. We do have a flag at the top of the release notes if there is a change in the API, since there is an expectation that the API won't be changed lightly. On the other hand, using BAO and other methods directly is more explicitly at-your-own-risk, even though most of us do it at least occasionally.

I'm concerned that many of the changes in a release will alter the behavior, signature, and/or output of various functions, and even if @alifrumin and I had the time to highlight them all, we'd bury the other stuff in doing so.