Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update select2 to latest 3.x + patches #15054

Merged
merged 1 commit into from
Aug 17, 2019
Merged

Update select2 to latest 3.x + patches #15054

merged 1 commit into from
Aug 17, 2019

Conversation

colemanw
Copy link
Member

Overview

This bumps up our patched version of Select2 to 3.5.4 and targets a tag instead of a branch for better composer integration.

@civibot
Copy link

civibot bot commented Aug 16, 2019

(Standard links)

@civibot civibot bot added the master label Aug 16, 2019
@colemanw
Copy link
Member Author

@totten this is related to #15044

@totten
Copy link
Member

totten commented Aug 17, 2019 •
edited
Loading

Test failures are unrelated.

I did some general click-around testing (r-run) of a few screens that rely on different variations of select2 (creating/viewing/editing contacts+locational-data+relationships), and they all seemed good. 👍

@totten totten merged commit 693fa3b into civicrm:master Aug 17, 2019
@colemanw colemanw deleted the select2 branch August 17, 2019 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @totten