dev/core#439 [Export] [Ref] Convert custom data export test to use newer function. #14937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the test & in the process fixes the handling for custom country fields to be where it is actually hit now. The code lines for custom fields are in a block that assumes 'type' will not be in the metadata for custom fields. That was one of these 'this is how the data is right this moment in time so I will build logic off it' type assumptions which riddles our code base.
Of course over time the metadata was fixed - leading to the assumption that custom fields would not have metadata being wrong. I have fixed it for the fields addressed in this test
Before
Old test helper
After
New test helper, parsing for country names longer than 16 chars
Technical Details
Part of general LeXIM cleanup to support extension leap on export UI
Comments