Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#439 [Export] [Ref] Convert custom data export test to use newer function. #14937

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fixes the test & in the process fixes the handling for custom country fields to be where it is actually hit now. The code lines for custom fields are in a block that assumes 'type' will not be in the metadata for custom fields. That was one of these 'this is how the data is right this moment in time so I will build logic off it' type assumptions which riddles our code base.

Of course over time the metadata was fixed - leading to the assumption that custom fields would not have metadata being wrong. I have fixed it for the fields addressed in this test

Before

Old test helper

After

New test helper, parsing for country names longer than 16 chars

Technical Details

Part of general LeXIM cleanup to support extension leap on export UI

Comments

@civibot
Copy link

civibot bot commented Jul 31, 2019

(Standard links)

@civibot civibot bot added the master label Jul 31, 2019
@eileenmcnaughton eileenmcnaughton changed the title [Export] [Ref] Convert custom data export test to use newer function. dev/core#439 [Export] [Ref] Convert custom data export test to use newer function. Jul 31, 2019
Fix handling for custom country fields to be where it is actually hit now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants