Revert "[REF] use generic loadStandardSearchOptionsFromUrl". Fix search selections.

[totten]

Overview

This reverts commit a5ca2ad
and fixes a bug in management of the prev/next cache. The
bug is visible when following this procedure:

1. In browser, use "Quick search" to search for text "am"
2. In browser, select checkboxes next to two items
3. In MySQL CLI, run select * from civicrm_prevnext_cache where is_selected =1;. Observe that there are two selections.
4. In browser, continue to next page. Observe that selection count drops to zero.
5. In MySQL CLI, re-run SQL query. Observe that the selections have disappeared.

Before

Proceeding to another page of search results causes loss of selections

After

Selections are preserved

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@totten i note this is against master but not 5.16?

[totten]

Thanks @seamuslee001. Fixed.

[totten]

This is fairly simple revert (based on bisecting to uncover the problem). FWIW, the difference appears to stem from changing the lookup params for force. The following is alternative patch that also fixes this issue for me.

diff --git a/CRM/Core/Form/Search.php b/CRM/Core/Form/Search.php
index 2957645991..4086c1b3a4 100644
--- a/CRM/Core/Form/Search.php
+++ b/CRM/Core/Form/Search.php
@@ -414,7 +414,7 @@ class CRM_Core_Form_Search extends CRM_Core_Form {
    */
   protected function loadStandardSearchOptionsFromUrl() {
     $this->_reset = CRM_Utils_Request::retrieve('reset', 'Boolean');
-    $this->_force = CRM_Utils_Request::retrieve('force', 'Boolean', $this, FALSE);
+    $this->_force = CRM_Utils_Request::retrieve('force', 'Boolean');
     $this->_limit = CRM_Utils_Request::retrieve('limit', 'Positive', $this);
     $this->_context = CRM_Utils_Request::retrieve('context', 'Alphanumeric', $this, FALSE, 'search');
     $this->_ssID = CRM_Utils_Request::retrieve('ssID', 'Positive', $this);

I've not investigated the goals/context/scope of the original change - so don't have an opinion on which framing is better.

[totten]

CC @monishdeb

[monishdeb]

Agree with this revert. Tested and does fix the issue mentioned in the PR description.