Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Export] [Test] Update 2 more tests to use new helper #14915

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Just a minor change within the test class to use the newer helper

Before

$this->doExport used as the helper

After

$this->doExportTest used as the helper

Technical Details

The goal is to switch fully to the new helper which
a) tests the actual output not intermediary steps
b) requires less code
c) allows us to take some munge back out of the main class (once all are switched)

Comments

@civibot
Copy link

civibot bot commented Jul 30, 2019

(Standard links)

@civibot civibot bot added the master label Jul 30, 2019
@seamuslee001
Copy link
Contributor

This only affects tests and the affected tests pass. Test failure is unrelated merging

@seamuslee001 seamuslee001 merged commit bebab62 into civicrm:master Jul 30, 2019
@seamuslee001 seamuslee001 deleted the ex_test branch July 30, 2019 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants