Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Export] Stop passing header rows around #14913

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 30, 2019

Overview

Minor code cleanup - use processor class method instead of passing $headers around

Before

Code less readable

After

Code more readable

Technical Details

$headers is specifically covered in various unit tests

Comments

@civibot
Copy link

civibot bot commented Jul 30, 2019

(Standard links)

@civibot civibot bot added the master label Jul 30, 2019
@eileenmcnaughton eileenmcnaughton changed the title Stop passing header rows around [REF] [Export] Stop passing header rows around Jul 30, 2019
@eileenmcnaughton
Copy link
Contributor Author

@colemanw wanna check this?

@colemanw
Copy link
Member

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants