Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] [Export] Remove now redundant param #14912

Merged
merged 1 commit into from
Jul 30, 2019
Merged

[REF] [Export] Remove now redundant param #14912

merged 1 commit into from
Jul 30, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 29, 2019 •
edited
Loading

Overview

Trivial cleanup

Before

Removes a parameter that is no longer needed

After

poof

Technical Details

sqlColumns is now being fetched from the processor
https://github.com/eileenmcnaughton/civicrm-core/blob/04e902163a71d714bdc9feeeb55c846a0e544e5c/CRM/Export/BAO/Export.php#L402

Comments

@civibot
Copy link

civibot bot commented Jul 29, 2019

(Standard links)

@civibot civibot bot added the master label Jul 29, 2019
@seamuslee001
Copy link
Contributor

adding MOP confirmed doing a grep these are the only 2 places that the code is referenced

@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001

@seamuslee001 seamuslee001 merged commit 4f86ebd into civicrm:master Jul 30, 2019
@seamuslee001 seamuslee001 deleted the export branch July 30, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001