Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php7.x warning on count #14896

Merged
merged 1 commit into from
Jul 28, 2019
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fixes a warning when php 7.2 tries to count on a null value
Before

Screen Shot 2019-07-28 at 1 34 03 PM

After

Gone

Technical Details

This error occurs if you try to do count on a variable that is NULL

Screen Shot 2019-07-28 at 1 33 55 PM

Comments

Fixes a warning when php 7.2 tries to count on a null value
@civibot
Copy link

civibot bot commented Jul 28, 2019

(Standard links)

@colemanw
Copy link
Member

Looks like a safe fix.

@mattwire
Copy link
Contributor

Noting that this fix is because the smarty tpl processor is doing a "count"

@mattwire mattwire merged commit 41f88c1 into civicrm:master Jul 28, 2019
@eileenmcnaughton eileenmcnaughton deleted the event_count branch August 11, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants