dev/core#1149 - Make it clearer which record the logging report is displaying #14889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As described in https://lab.civicrm.org/dev/core/issues/1149 the report at "Reports - Contact Reports - Contact Logging Report (Summary)" says it's showing records for activities but it's actually showing activity_contact log records.
Before
Log type shows as "Activity"
After
Log type shows as "Activity Contact"
Comments
As described in the ticket there is additionally some grouping going on that prevents actually seeing the whole sequence of activity_contact transactions, and the logging itself doesn't seem to track the activity_contact when the activity itself is deleted. This PR doesn't attempt to fix any of that.
It also doesn't attempt to fix the word "Case" which is actually showing some combination of Case_Contact and I dunno what (maybe the contact whose id matches the case_type_id - I gave up looking).