Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1149 - Make it clearer which record the logging report is displaying #14889

Merged

Conversation

demeritcowboy
Copy link
Contributor

Overview

As described in https://lab.civicrm.org/dev/core/issues/1149 the report at "Reports - Contact Reports - Contact Logging Report (Summary)" says it's showing records for activities but it's actually showing activity_contact log records.

Before

Log type shows as "Activity"

After

Log type shows as "Activity Contact"

Comments

As described in the ticket there is additionally some grouping going on that prevents actually seeing the whole sequence of activity_contact transactions, and the logging itself doesn't seem to track the activity_contact when the activity itself is deleted. This PR doesn't attempt to fix any of that.

It also doesn't attempt to fix the word "Case" which is actually showing some combination of Case_Contact and I dunno what (maybe the contact whose id matches the case_type_id - I gave up looking).

@civibot
Copy link

civibot bot commented Jul 26, 2019

(Standard links)

@civibot civibot bot added the master label Jul 26, 2019
@eileenmcnaughton
Copy link
Contributor

Seems fine to me - it's a minor improvement

@eileenmcnaughton eileenmcnaughton merged commit 8ceb9c2 into civicrm:master Jul 29, 2019
@demeritcowboy demeritcowboy deleted the logging-report-clarification branch August 14, 2019 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants