CRM-20455 - Allow CRM_Core_DAOTest to pass w/packages#259

[totten]

Overview

This is a supplement to CRM-20455 and esp civicrm/civicrm-packages#259.

Before

CRM_Core_DAOTest passes with current code, but it fails with packages#259 because:

1. A function signature needs changing.
2. CiviUnitTestCase::setUp() effectively calls Civi\Core\Container::boot() multiple times (once via Civi::reset() and then via CRM_Core_Config::singleton()), which initializes various services twice in a row. This creates a mismatch in the lifecycle of Civi::$statics and dispatcher (such that Civi::$statics may retain a stale copy of dispatcher).

After

CRM_Core_DAOTest passes with either current code or with packages#259

Comments

For sub-item #1, the changed tests/functions are new; the signature change occurs mid-dev-cycle.

For sub-item #2, any change to initialization in CiviUnitTestCase::setUp() makes me nervous on account of the code's centrality. But fortunately, the reinitialization still runs at the same time (just non-duplicatively), and the test-suite shows a green light.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).