[Test] [Import] Add test to demonstrate bug that turns out not to exist #14880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
cust_field_label
branch
2 times, most recently
from
8acc3e8 to
f7bb6d4
Compare
I thought there was a bug in import handling in custom data so I wrote a test to try to capture it - tests pass & I'm off to re-check my data & see if the bug was more of a pebkac error. Anyway test is good
eileenmcnaughton
force-pushed
the
cust_field_label
branch
from
2f6c2d2 to
a0c6165
Compare
| FALSE, FALSE, NULL, NULL, FALSE, FALSE, FALSE | ||
| ); | ||
| } | ||
| $customFields = CRM_Core_BAO_CustomField::getFields(CRM_Utils_Array::value('contact_type', $values), |
There was a problem hiding this comment.
cached in getFields
| if ($contactFields == NULL) { | ||
| $contactFields = CRM_Contact_DAO_Contact::import(); | ||
| } | ||
| $contactFields = CRM_Contact_DAO_Contact::import(); |
There was a problem hiding this comment.
cached in CRM_Contact_DAO_Contact::import
|
Changes look fine to me and we should have sufficient test coverage here merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a test
Before
Less tests
After
More tests
Technical Details
I thought there was a bug in import handling in custom data so I wrote a test to try to capture it - tests pass & I'm off to re-check
my data & see if the bug was more of a pebkac error.
Anyway test is good
Comments