Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] extract loadSavedMapping #14873

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 24, 2019

Overview

This is a very 'untouched' extraction so that it can be reviewed / replicated easily. Ideally more follow up will be in subsequent PRs (now or down the track)

Before

One long function

After

One IF's worth in it's own function

Technical Details

Ideally we would use the same functions as the export does now we have improved functions for this stuff & no-one will ever have to make sense of this stuff again.

Comments

@civibot
Copy link

civibot bot commented Jul 24, 2019

(Standard links)

@civibot civibot bot added the master label Jul 24, 2019
This is a very 'untouched' extraction for simple replication. Ideally more follow up will be in subsequent PRs (now or down the track
@colemanw colemanw merged commit 3d41bd9 into civicrm:master Jul 24, 2019
@colemanw colemanw deleted the extract branch July 24, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants