Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORT] [code quality] [REF] Improve readability of variable assignment #14871

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Improves variable assignment

Before

Code hard to read. Variables assigned using $$ which makes them hard to track in an IDE

After

Variables are keys in an array. More readable

Technical Details

This is all just preliminary cleanup to fixing a known bug

Comments

@civibot
Copy link

civibot bot commented Jul 24, 2019

(Standard links)

@civibot civibot bot added the master label Jul 24, 2019
@eileenmcnaughton eileenmcnaughton merged commit ef40a08 into civicrm:master Jul 24, 2019
@eileenmcnaughton eileenmcnaughton deleted the import_post branch July 24, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants