Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORT] [code-quality] Remove usage of nullArray #14869

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 24, 2019

Overview

Just removes a deprecated code pattern

Before

Use of never good & sometimes actively harmful nullArray

After

Poof

Technical Details

Most of these got removed once we found out they caused intermittent test fails but I just hit this one when trying to familiarise myself with import code

Comments

@civibot
Copy link

civibot bot commented Jul 24, 2019

(Standard links)

@civibot civibot bot added the master label Jul 24, 2019
@eileenmcnaughton eileenmcnaughton changed the title Remove usage of nullArray [IMPORT] [code-quality] Remove usage of nullArray Jul 24, 2019
@eileenmcnaughton eileenmcnaughton merged commit b94ff65 into civicrm:master Jul 24, 2019
@eileenmcnaughton eileenmcnaughton deleted the import branch July 24, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants