Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/event#9 Event Templates: do not set the Start/End dates #14862

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

mlutfy
Copy link
Member

@mlutfy mlutfy commented Jul 23, 2019

Overview

When creating an event using an event template, the Start Date is automatically set to the date when the template was created.

To reproduce:

  • Create an Event Template (Administer > Events > Event Templates)
  • Wait one day, or set the start_date to some past date (templates are saved as regular events in the civicrm_event database table).
  • Create a new Event, and use the template that was created.
  • Notice how the start date is automatically set.

This might not sound like a big deal, but when the event template was created in 2015, it gets pretty annoying to have to also click to change the year (and it's easy to overlook).

This was also reported on Stack Exchange:
https://civicrm.stackexchange.com/questions/28159/event-template-start-date

Gitlab issue: https://lab.civicrm.org/dev/event/issues/9

Before

Start Date is automatically set to some old date in the past.

After

Start Date is not set.

Technical Details

I also unset end_date as a precaution. It should not be set, but if someone created a template from an existing event, it could.

@civibot
Copy link

civibot bot commented Jul 23, 2019

(Standard links)

@civibot civibot bot added the master label Jul 23, 2019
@mattwire
Copy link
Contributor

Reviewed and tested by @lcdservices here https://lab.civicrm.org/dev/event/issues/9#note_20934 I've tested and approve this change.

@mattwire mattwire merged commit 7abd0f3 into civicrm:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants