Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in Atomfeeds deprecation now that the extension has a new release… #14856

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

seamuslee001
Copy link
Contributor

… with converted cache mechanism

Overview

Now that the Atomfeeds extension has a new release https://github.com/Chirojeugd-Vlaanderen/atomfeeds/releases/tag/0.1-alpha3 which incorporates a cache conversion we should implement the same deprecation here as with multisite and entity setting

Before

No deprecation

After

Deprecation as newer version of extension correctly uses newer cache mechanism

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Jul 22, 2019

(Standard links)

@civibot civibot bot added the master label Jul 22, 2019
@seamuslee001 seamuslee001 force-pushed the atomfeeds_cache_convert branch from 77e2dab to 5b3ae62 Compare July 22, 2019 21:33
… with converted cache mechanism

Fix version to match info.xml of new version
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 at the moment you still have to add a define to civicrm.settings.php to opt into this?

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton yes but also the more that use the Civi::cache then are doing things PSR16 format

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 OK -yes I agree this is good to do - I just want to understand the steps to get switched over & I think maybe the first is to ensure we have some live testing of the define followed by making it the default on new installs

@seamuslee001
Copy link
Contributor Author

Test fail unrelated

@seamuslee001 seamuslee001 merged commit 659b4b6 into civicrm:master Jul 23, 2019
@seamuslee001 seamuslee001 deleted the atomfeeds_cache_convert branch July 23, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants